Repository navigation
Add support for building and testing Root on Windows ARM64 - #24128
Closed
MugundanMCW wants to merge 3 commits into
Closed
MugundanMCW wants to merge 3 commits into
MugundanMCW wants to merge 3 commits into
Conversation
Build and test fixes for MSVC ARM64 (windows-11-arm): - cling: on Windows ARM64, mark external globals and address-taken functions as dllimport before JIT compilation, so they are reached through __imp_ slots instead of out-of-range (+/-4 GB) PC-relative references. - cling: prefer ucrtbase.dll over legacy msvcrt.dll when a symbol resolves into msvcrt, avoiding CRT state corruption (stdout/fflush). - cling: allocate JIT memory per section on Windows ARM64. - llvm: AArch64 GlobalISel falls back to SelectionDAG for Win64 functions with an inreg sret argument, so the sret pointer is returned in x0 as the MSVC ABI requires. - llvm: RuntimeDyld COFF/AArch64 scales the PAGEOFFSET_12L addend by the load/store access size. - core: ARM64 implementations of TWinNTSystem::GetCPUSpeed and GetL2CacheSize; guard GetLibraries against an unset %LIB%. - cmake: MACHINE_ARCH=ARM64 for ACLiC; civetweb MSVC ARM64 detection. - tests: disable test-check-nullptr on Windows ARM64 (no JIT unwind info registration, as on macOS arm64); skip browser-based tests on Windows when wmic is not available; stresshistogram-interpreted is not expected to fail on ARM64. - ci: new Windows ARM64 workflow, with fftw3 from vcpkg. ctest on Windows 11 ARM64: 1011/1012 passing (was 867/1010).
MugundanMCW
requested review from
bellenot,
dpiparo,
hahnjo,
pcanal and
vgvassilev
as code owners
November 13, 2026 03:25
Member
|
Thanks for the PR. Presently we are not planning to add that platform to the battery. Should you encounter any problem with it, please do not hesitate to reach out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #
This PR fixes the compilation errors and the test failures faced on Windows ARM64