[cmake] raise min required version to 3.26 - #23537
Draft
ferdymercury wants to merge 5 commits into
Draft
ferdymercury wants to merge 5 commits into
ferdymercury wants to merge 5 commits into
Conversation
This version of CMake was released in March 2022 https://github.com/Kitware/CMake/releases/tag/v3.23.0 This version is required to use FILE_SETs, which could help towards root-project#16327 and root-project#18419. Since cmake_minimum_required updates the cmake_policy from 3.20 to 3.23, we need to take care of a change that happened from 3.20 to 3.21 that leads to an error in the CheckCompiler CMake module, so set the proper policy flag to old to avoid that error on some platforms.
Contributor
|
Thank you! So if everything goes to plan, this PR should only fail on Ubuntu 22.04 here |
Collaborator
Author
If I recall correctly, Ubuntu 22.04 CI-image was using a custom CMake installation in /opt? |
Collaborator
Author
|
Debian13 seems stuck. All the rest looks good / unrelated CI failures. |
Test Results 21 files 21 suites 3d 15h 16m 30s ⏱️ For more details on these failures, see this check. Results for commit 9913ac9. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Do not merge yet, is for 6.44
Expansion of #19941
exploring future according to #23385