[ziplib] make it private and isolate it from ROOT - #23270
Draft
ferdymercury wants to merge 3 commits into
Draft
ferdymercury wants to merge 3 commits into
ferdymercury wants to merge 3 commits into
Conversation
ferdymercury
changed the title
ferdymercury
force-pushed
the
bzipnope
branch
from
September 5, 2026 21:55
31568ec to
d82e7a8
Compare
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit c602830. ♻️ This comment has been updated with latest results. |
ferdymercury
force-pushed
the
bzipnope
branch
from
September 5, 2026 21:55
d82e7a8 to
34ec227
Compare
ferdymercury
force-pushed
the
bzipnope
branch
4 times, most recently
from
September 7, 2026 18:01
7e46954 to
570c834
Compare
ferdymercury
added
skip code analysis
ferdymercury
force-pushed
the
bzipnope
branch
from
September 7, 2026 18:06
570c834 to
b0094bd
Compare
ferdymercury
changed the title
ferdymercury
marked this pull request as ready for review
September 7, 2026 18:12
ferdymercury
requested review from
bellenot,
dpiparo and
pcanal
as code owners
September 7, 2026 18:12
1 of 2 tasks
pcanal
reviewed
Sep 8, 2026
| @@ -0,0 +1,25 @@ | |||
| #ifndef R__unlikely_h | |||
Member
There was a problem hiding this comment.
This header file/macros does not belong here per se. It is not specific to the zip library and is already in RConfig.hxx (so now this is duplicated ....). Is there a better solution?
Collaborator
Author
There was a problem hiding this comment.
I could not think a much better one, or not if we want to unbundle ziplib from core (thinking from a Debian packager perspective of independence / self-containment.)
Collaborator
Author
There was a problem hiding this comment.
In any case, this duplication would be temporary, when the ROOT's C++ standard minimum is raised to C++20, all this can be fully removed by [[unlikely]].
ferdymercury
force-pushed
the
bzipnope
branch
2 times, most recently
from
September 10, 2026 15:39
7d8b31a to
8de2fa9
Compare
ferdymercury
marked this pull request as draft
September 10, 2026 17:33
ferdymercury
force-pushed
the
bzipnope
branch
from
September 10, 2026 17:34
8de2fa9 to
d2cfc2c
Compare
ferdymercury
force-pushed
the
bzipnope
branch
from
September 11, 2026 09:59
d2cfc2c to
82ffb75
Compare
so that it is a real builtin. TODO: potentially move TLS header to builtins
otherwise zlib.h not found
ferdymercury
force-pushed
the
bzipnope
branch
from
September 11, 2026 12:57
82ffb75 to
68ba40f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by strategies within #23261.
Would also need first #23271
In a future step one could also move the TLS header.
The good thing about making it private is that later then one can replace this with whatever else more modern library if needed.