[cmake] Make explicit that all dictionaries depend on Core.pcm - #23207
ferdymercury wants to merge 7 commits into
Conversation
By pcanal They depend on it implicitly and not expressing leads to missing rebuilds as seen at: root-project#23046 when no ARG_DEPENDENCIES are specified at all
ferdymercury
changed the title
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
Test Results 21 files 21 suites 3d 6h 45m 50s ⏱️ For more details on these failures, see this check. Results for commit 9e39f7f. ♻️ This comment has been updated with latest results. |
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
It looks good to me ... but still need another approval since this is partially my own code :)
|
This code is fixing the original issues (appeared at #23046) as seen at https://github.com/root-project/root/actions/runs/33461288283 |
|
@hageboeck @bellenot Could you review this? Thanks. |
|
gentle ping @hageboeck since it's needed for advancing with #23046 |
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
LGTM.
Applying these changes didn't fix the nightly build issues, but adding the dependency seems like the right thing to do.
|
Close/reopen to force a full rebuild. |
|
It seems that the CI failures are unrelated (RNTuple daos code not updated for deprecated header, un-ability to fetch the repository and failure in http test). |
This branch has not been deployed
3 participants
By pcanal
They depend on it implicitly and not expressing leads to missing rebuilds as seen at: #23046
when no ARG_DEPENDENCIES are specified at all