Skip to content

[ntuple] fix cloning RStreamerField #22979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jblomer merged 1 commit into from
Aug 2, 2026
+6 −1
Merged

[ntuple] fix cloning RStreamerField #22979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tree/ntuple/src/RFieldMeta.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,7 +1547,8 @@ ROOT::RStreamerField::RStreamerField(std::string_view fieldName, TClass *classp)

std::unique_ptr<ROOT::RFieldBase> ROOT::RStreamerField::CloneImpl(std::string_view newName) const
{
return std::unique_ptr<RStreamerField>(new RStreamerField(newName, GetTypeName()));
// To get the correct TClass instance in the clone, we clone using the un-normalized type name
return std::unique_ptr<RStreamerField>(new RStreamerField(newName, fClass->GetName()));
}

std::size_t ROOT::RStreamerField::AppendImpl(const void *from)
Expand Down
4 changes: 4 additions & 0 deletions tree/ntuple/test/rfield_class.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,10 @@ TEST(RNTuple, TClassMetaName)
ROOT::RStreamerField f6("f", "EdmWrapper<long long>");
EXPECT_STREQ("EdmWrapper<Long64_t>", f6.GetClass()->GetName());
EXPECT_EQ("EdmWrapper<Long64_t>", f6.GetTypeAlias());
auto clone = f6.Clone("f");
auto streamerFieldPtr = static_cast<ROOT::RStreamerField *>(clone.get());
EXPECT_STREQ("EdmWrapper<Long64_t>", streamerFieldPtr->GetClass()->GetName());
EXPECT_EQ("EdmWrapper<Long64_t>", streamerFieldPtr->GetTypeAlias());
}

TEST(RNTuple, StreamerInfoRecords)
Expand Down
Loading