Skip to content

[XRF] Remove the silent change of the asimov null hypothesis #22973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Phmonski wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −8
Open

[XRF] Remove the silent change of the asimov null hypothesis #22973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions roofit/xroofit/src/xRooNLLVar.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,14 +1775,6 @@ std::shared_ptr<xRooNLLVar::xRooHypoPoint> xRooNLLVar::xRooHypoPoint::asimov(boo
// dynamic_cast<RooRealVar *>(p)->removeRange("physical"); -- can't use this as will modify shared property
if (auto v = dynamic_cast<RooRealVar *>(p)) {
v->deleteSharedProperties(); // effectively removes all custom ranges
if (v->getVal() == 0) {
// for discovery tests, we generate asimov at mu!=0 and then evaluate the two sided
// at some value of mu. Normally we would use mu=0 but if we have a bin
// with only signal contribution (no bkg) will get asimov data in that bin
// and no prediction ... the cfit(mu=0) will never succeed on this
// so lets move to half the alt value instead (the value used to generate)
v->setVal(theFit->constPars().getRealValue(v->GetName()) * 0.5);
}
}
}

Expand Down
Loading