Skip to content

Add plataberget network - #1269

Merged
0xfornax merged 6 commits into
masterfrom
add-plataberget-network
Oct 7, 2026
Merged

0xfornax merged 6 commits into
masterfrom
add-plataberget-network

Conversation

@0xfornax

@0xfornax 0xfornax commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

This PR adds Plataberget as a network option. It also allows clients to run on networks without RP contracts.

@0xfornax
0xfornax force-pushed the add-plataberget-network branch 4 times, most recently from b2d37c4 to 4f42a42 Compare October 7, 2026 14:43
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Coverage Report

1 similar comment
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Coverage Report

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Coverage Report

@0xfornax
0xfornax force-pushed the add-plataberget-network branch from 4f42a42 to fc70634 Compare October 7, 2026 18:48
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Coverage Report

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (3 decrease, 7 increase)

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/node 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool-cli/service 0.19% (+0.19%) 👍
github.com/rocket-pool/smartnode/rocketpool-cli/service/config 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool/api/node 2.79% (+0.52%) 👍
github.com/rocket-pool/smartnode/rocketpool/node 0.39% (-0.13%) 👎
github.com/rocket-pool/smartnode/rocketpool/watchtower 0.59% (-0.17%) 👎
github.com/rocket-pool/smartnode/shared/services 0.84% (+0.59%) 👍
github.com/rocket-pool/smartnode/shared/services/beacon/client 1.00% (+0.58%) 👍
github.com/rocket-pool/smartnode/shared/services/config 10.08% (+3.91%) 👍
github.com/rocket-pool/smartnode/shared/services/rewards/ssz_types 3.04% (-0.80%) 👎
github.com/rocket-pool/smartnode/shared/services/rocketpool 0.49% (+0.49%) 👍
github.com/rocket-pool/smartnode/shared/types/config 12.65% (+6.77%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/node/sync.go 0.00% (ø) 2073 (+562) 0 2073 (+562)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/choice-wizard-step.go 0.00% (ø) 2052 (+475) 0 2052 (+475)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/config-form.go 0.00% (ø) 3040 (+581) 0 3040 (+581)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-home.go 0.00% (ø) 5946 (+1428) 0 5946 (+1428)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/standard-layout.go 0.00% (ø) 5714 (+1694) 0 5714 (+1694)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/step-external-cc.go 0.00% (ø) 1028 (+299) 0 1028 (+299)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/step-local-cc.go 0.00% (ø) 2493 (+614) 0 2493 (+614)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/step-local-ec.go 0.00% (ø) 2072 (+518) 0 2072 (+518)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/step-native-cc.go 0.00% (ø) 956 (+283) 0 956 (+283)
github.com/rocket-pool/smartnode/rocketpool-cli/service/service.go 0.06% (+0.06%) 36682 (+8027) 22 (+22) 36660 (+8005) 👍
github.com/rocket-pool/smartnode/rocketpool/api/node/status.go 0.00% (ø) 13242 (+2225) 0 13242 (+2225)
github.com/rocket-pool/smartnode/rocketpool/node/node.go 0.00% (ø) 11055 (+3194) 0 11055 (+3194)
github.com/rocket-pool/smartnode/rocketpool/watchtower/watchtower.go 0.00% (ø) 8896 (+2268) 0 8896 (+2268)
github.com/rocket-pool/smartnode/shared/services/beacon/client/std-http-client.go 0.69% (+0.69%) 20199 (+5051) 139 (+139) 20060 (+4912) 👍
github.com/rocket-pool/smartnode/shared/services/beacon/client/types.go 4.12% (+1.49%) 582 (+126) 24 (+12) 558 (+114) 👍
github.com/rocket-pool/smartnode/shared/services/config/images.go 9.16% (+9.16%) 12693 (+12693) 1163 (+1163) 11530 (+11530) 👍
github.com/rocket-pool/smartnode/shared/services/config/network-clients.go 14.89% (+14.89%) 1995 (+1995) 297 (+297) 1698 (+1698) 🎉
github.com/rocket-pool/smartnode/shared/services/config/networks-config.go 16.92% (+5.22%) 4309 (+837) 729 (+323) 3580 (+514) 👍
github.com/rocket-pool/smartnode/shared/services/config/rocket-pool-config.go 9.73% (+3.94%) 31465 (+7473) 3060 (+1671) 28405 (+5802) 👍
github.com/rocket-pool/smartnode/shared/services/ec-manager.go 0.19% (+0.19%) 9322 (+2049) 18 (+18) 9304 (+2031) 👍
github.com/rocket-pool/smartnode/shared/services/rewards/ssz_types/json.go 3.67% (-0.77%) 5365 (+1197) 197 (+12) 5168 (+1185) 👎
github.com/rocket-pool/smartnode/shared/services/rocketpool/client.go 0.42% (+0.42%) 26604 (+6798) 112 (+112) 26492 (+6686) 👍
github.com/rocket-pool/smartnode/shared/services/services.go 2.46% (+2.46%) 5888 (+1389) 145 (+145) 5743 (+1244) 👍
github.com/rocket-pool/smartnode/shared/types/config/network.go 13.94% (+7.02%) 330 (+70) 46 (+28) 284 (+42) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/shared/services/beacon/client/slot-duration_test.go
  • github.com/rocket-pool/smartnode/shared/services/config/networks-config_test.go
  • github.com/rocket-pool/smartnode/shared/services/rewards/ssz_types/network_test.go

@0xfornax
0xfornax merged commit cda6a9d into master Oct 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant