Drop ADT4_* variables from the chatdsg demo service - #1
Draft
harelb wants to merge 1 commit into
Draft
Conversation
chatdsg.py is configured from HERACLES_NEO4J_URI, which this service already sets, so ADT4_HERACLES_IP and ADT4_HERACLES_PORT are dead config. They only existed because chatdsg.py built its URI from that pair, which it no longer does. Requires robustrobotics/heracles_agents#2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to robustrobotics/heracles_agents#2, which makes
chatdsg.pyconfigurable entirely throughHERACLES_*variables so heracles_agents can run without the larger ADT4 stack.The
chatdsgservice already setsHERACLES_NEO4J_URI: neo4j://neo4j:7683, which is whatchatdsg.pynow reads.ADT4_HERACLES_IPandADT4_HERACLES_PORTonly existed becausechatdsg.pyandexamples/chatdsg/agent_config.yamlbuilt the Neo4j URI from that pair; both now use$HERACLES_NEO4J_URI, so these two lines are dead config.No other service referenced them — this was the only occurrence in the repo.
Merge order: this depends on robustrobotics/heracles_agents#2. Landing it first would break the
chatdsgdemo, since the currentchatdsg.pystill reads the ADT4 names.Testing: not exercised via docker-compose. The equivalent configuration was verified outside Docker —
chatdsg.pyloads a DSG with everyADT4_*variable unset, given onlyHERACLES_NEO4J_URI,HERACLES_NEO4J_USERNAME,HERACLES_NEO4J_PASSWORD,HERACLES_AGENTS_PATHandHERACLES_OPENAI_API_KEY, which is exactly the set this service provides. Adocker compose run --rm chatdsgcheck against the built image would be worth doing before this leaves draft.