Repository navigation
Takes conventions v1.52.0 - #394
Merged
Merged
Conversation
The family resync moves robertblust/conventions in `conventions.json` from v1.51.0 to v1.52.0. The upstream notes are at https://github.com/robertblust/conventions/releases/tag/v1.52.0. Verified: `sh conventions/conventions-sync sync`, `npm ci`, `./tts/generate.py --dry-run`, `python3 -m unittest discover -s talks/deciding-well -p 'test_*.py'`, `npm run test:dupes`, `npm run test:cost`, `npm run test:build`, `npm run pages:check`, `GITHUB_TOKEN=${GITHUB_TOKEN:-$(gh auth token)} npm run pin:check`, `npm run design:check`, `npm run sitemap:check`, `npm run test:og`, `npm run og:check`, `GITHUB_TOKEN=${GITHUB_TOKEN:-$(gh auth token)} npm run model:check` and `PORT=$(python3 -c 'import socket; s = socket.socket(); s.bind(("127.0.0.1", 0)); print(s.getsockname()[1])'); ./node_modules/.bin/design serve --port $PORT & SERVER_PID=$!; sleep 1; BASE=http://127.0.0.1:$PORT npm run verify && npx design links --base http://127.0.0.1:$PORT; STATUS=$?; kill $SERVER_PID; exit $STATUS` passed. Process: Delivery Phase: Implement Track: Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The family resync moves robertblust/conventions in
conventions.jsonfrom v1.51.0 to v1.52.0. The upstream notes are at https://github.com/robertblust/conventions/releases/tag/v1.52.0.Verified:
sh conventions/conventions-sync sync,npm ci,./tts/generate.py --dry-run,python3 -m unittest discover -s talks/deciding-well -p 'test_*.py',npm run test:dupes,npm run test:cost,npm run test:build,npm run pages:check,GITHUB_TOKEN=${GITHUB_TOKEN:-$(gh auth token)} npm run pin:check,npm run design:check,npm run sitemap:check,npm run test:og,npm run og:check,GITHUB_TOKEN=${GITHUB_TOKEN:-$(gh auth token)} npm run model:checkandPORT=$(python3 -c 'import socket; s = socket.socket(); s.bind(("127.0.0.1", 0)); print(s.getsockname()[1])'); ./node_modules/.bin/design serve --port $PORT & SERVER_PID=$!; sleep 1; BASE=http://127.0.0.1:$PORT npm run verify && npx design links --base http://127.0.0.1:$PORT; STATUS=$?; kill $SERVER_PID; exit $STATUSpassed.