chore(tests): drive RPC over goridge net/rpc again - #130
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Go test harness to drive the KV RPC surface over goridge net/rpc again (instead of Connect-RPC), while keeping the current api-go message types, as part of the org-wide Connect-RPC revert.
Changes:
- Replaced Connect-RPC HTTP/2 client usage with a goridge
net/rpcclient in the KV storage plugin test. - Updated test module dependencies to drop Connect-related deps and pin RoadRunner components (and goridge) to revert-branch pseudo-versions.
- Adjusted test assertions to work with direct protobuf response structs (rather than Connect response wrappers).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/storage_plugin_test.go | Switches test RPC calls from Connect client methods to goridge net/rpc client.Call(...) with protobuf request/response types. |
| tests/go.mod | Removes Connect-related dependencies, adds goridge, and pins RoadRunner deps to pseudo-versions for the revert. |
| tests/go.sum | Updates checksums to match removed Connect deps and newly pinned/added dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 65.00% 65.00%
=======================================
Files 1 1
Lines 20 20
=======================================
Hits 13 13
Misses 4 4
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Use t.Fatal instead of assert.NoError in newRPCClient so a persistently failing dial aborts the helper cleanly instead of proceeding with a nil conn and panicking in the rpc client input goroutine. Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
|
Warning Review limit reached
Next review available in: 28 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Part of the org-wide Connect-RPC revert: test helpers drive the RPC surface over goridge net/rpc again, keeping the current api-go message set. Plugin deps in tests/go.mod are pinned to the revert branches (pseudo-versions to be replaced by tags). No changes outside tests/.