fix(group-translate): parse res.body instead of res.json()#11
Merged
Conversation
…ons were a silent no-op) The sandboxed ctx.net.fetch returns the response body as a string with no .json() method (functions can't cross the worker structuredClone boundary), so res.json() threw on every call and the client failed open — translations never applied. Parse res.body directly. Tests now use the real runtime shape. Closes #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sandboxed
ctx.net.fetchreturns the response body as a string with no.json()method (functions can't cross the workerstructuredCloneboundary), sores.json()threw on every call and the LibreTranslate client failed open — translations never applied (a silent no-op). The client now parsesres.bodydirectly.Tests are updated to the real runtime shape (
bodystring,json()unavailable), which reproduces the bug then verifies the fix.v1.0.3→v1.0.4. Full repo gate green (tsc, 139 tests, catalog).Closes #10