WI-004: #17 Missing response helpers: Accepted, NoContent

[rluders]

Work item WI-004 of work package WP-001 (GitHub issues).

`response_helpers.go` has `OK`, `OKWithMeta`, and `Created`, but no `Accepted` (202) or `NoContent` (204) — both common for async-job-style and delete/update-with-empty-body endpoints. `ReplyBuilder` (the fluent path) has the same gap: `OK`/`Created` methods exist, no `Accepted`/`NoContent`.

Current workaround is the generic `Respond(data).Status(http.StatusAccepted).Write(w)` / `Respondany.Status(http.StatusNoContent).Write(w)`, which works but is exactly the "low-level escape hatch" the direct helpers exist to avoid.

Requested:
```go
func Accepted[T any](w http.ResponseWriter, data T)
func NoContent(w http.ResponseWriter)
```
plus `ReplyBuilder.Accepted`/`ReplyBuilder.NoContent` for the header/meta-configured path.

Implemented by the Weave Autoloop, attempt 1, execution exe_b61112dcc128.

Changed files:

• response_builder.go
• response_helpers.go
• response_helpers_test.go

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.88%. Comparing base (9b55b5e) to head (e5087ef).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   83.60%   83.88%   +0.28%     
==========================================
  Files          14       14              
  Lines         500      509       +9     
==========================================
+ Hits          418      427       +9     
  Misses         63       63              
  Partials       19       19              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rluders]

Weave review: approved (execution exe_a9d7dbfdcaaf)

• Reviewer by agent go-reviewer: approved — The change meets all four acceptance criteria and each one has a test. go vet ./... and go test -count=1 ./... both exited 0 (report.json:4-12). I didn't run them myself, so that rests on the report.

Criterion	Implementation	Test
Accepted[T any](w, data) helper (202)	response_helpers.go:20-23, delegating to Reply().Accepted	response_helpers_test.go:39-48 checks the 202 status and a non-empty body
NoContent(w) helper (204)	response_helpers.go:25-28	response_helpers_test.go:50-59 checks the 204 status and an empty body
ReplyBuilder.Accepted with header and meta	response_builder.go:82-85 goes through Respond(...).Status(202).Meta().Headers().Write, so it matches how Created is built	response_helpers_test.go:63-66 sets a header and meta and checks the 202 status and the header
ReplyBuilder.NoContent with headers	response_builder.go:89-92 applies headers with the existing applyHeaders (response_write.go:91), then calls WriteHeader(204)	response_helpers_test.go:69-78 checks the 204 status, the header, an empty body and no Content-Type

• Minimal: the change adds only the four functions and their tests.
• Idiomatic: the new code follows the style of the existing helpers, and every public function has a doc comment.
• 204 handling: NoContent skips the JSON writer, so there's no body or Content-Type. Meta is ignored, and the doc comment says so.

Two small gaps, neither of which blocks approval:

• The 202 tests don't assert the Content-Type or the meta in the body.
• NoContent on the direct helper doesn't check for a stray Content-Type, though the builder test does.
• Person: approved — Operator review (Orkestra dogfood operator; NOT a GitHub review): diff read. Accepted/NoContent helpers and ReplyBuilder methods follow the existing Created pattern; NoContent writes headers and 204 with no body or Content-Type. Tests cover all four. CI observed by Orkestra (ci_passed at e5087ef). Ready for a human merge decision.