Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
name: Go lint
runs-on: ubuntu-latest
env:
GOLANGCI_LINT_VERSION: v2.11.4
GOLANGCI_LINT_VERSION: v2.13.1
GOPROXY: https://proxy.golang.org,https://u:${{ secrets.RIVERPRO_GO_MOD_CREDENTIAL }}@riverqueue.com/goproxy,direct
permissions:
contents: read
Expand Down
7 changes: 7 additions & 0 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,15 @@ linters:
default: all

disable:
# disabled because they have replacements enabled by default
- gomodguard # replaced by gomodguard_v2

# disabled, but which we should enable with discussion
- wrapcheck # checks that errors are wrapped; currently not done anywhere

# disabled because we're not compliant, but which we should think about
- exhaustruct # checks that properties in structs are exhaustively defined; may be a good idea
- exhaustruct_v5 # replacement for exhaustruct
- testpackage # requires tests in test packages like `river_test`

# disabled because they're annoying/bad
Expand Down Expand Up @@ -50,6 +54,9 @@ linters:
- msg: Use built-in `min` function instead.
pattern: \bmath\.Min\b

goconst:
ignore-tests: true

gomoddirectives:
replace-local: true

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ func (req *workflowListRequest) ExtractRaw(r *http.Request) error {
}

if state := r.URL.Query().Get("state"); state != "" {
req.State = (state)
req.State = state
}

return nil
Expand Down
Loading