Fix periodic state advance on insert error - #1359
Open
BreezeDelegate wants to merge 2 commits into
Open
Conversation
Contributor
|
Hah, we actually had one other person find this in #1348, but they stopped replying to the PR. Do you want to add a changelog entry and add yourself to the CLA? https://github.com/riverqueue/rivercla |
Author
|
Yep, happy to. I added the changelog entry. For the CLA, is it okay to sign under my usual GitHub name/pseudonym (BreezeDelegate) rather than publishing my legal name? |
Contributor
Okay that works. Just make sure changes are tied back to the same GitHub handle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops
insertBatchbefore the durablenext_run_atupsert when periodic job insertion fails.Adds a regression test for the insert-error path.
Fixes #1304