Upgrade to Go 1.27 + golangci-lint 2.13.1 - #1356
Merged
Merged
Conversation
bgentry
approved these changes
Aug 21, 2026
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
Looks like there's an old linter to fix but otherwise LGTM
brandur
force-pushed
the
brandur-go-1.27
branch
3 times, most recently
from
August 21, 2026 22:22
3673fe3 to
84a52fd
Compare
Just since everything's fully available in Homebrew etc. now, here take the opportunity upgrade Go to 1.27 and golangci-lint to 2.13.1 so we can get our lint CI fully passing again.
brandur
force-pushed
the
brandur-go-1.27
branch
from
August 21, 2026 22:33
84a52fd to
131a3a2
Compare
Merged
brandur
added a commit
that referenced
this pull request
Aug 22, 2026
Follows up #1356 to bring back in some modernizers that I'd disabled to not make the diff for that original PR gigantic. In particular: * `errorsastype`: Requires the use of the new `errors.AsType` helper. This is a really nice one and turns this old code: var pgErr *pgconn.PgError if errors.As(err, &pgErr) { Into this much nicer generics variant: if pgErr, ok := errors.AsType[*pgconn.PgError](err); ok { * `newexpr`: Converts pointer helpers like `ptrutil.Ptr(...)` to `new`. I remove all uses of `ptrutil.Ptr(...)`, but left its definition in `rivershared` for now because I think it'll allow a little more flexibility in what version of River a River Pro installation can use. For example, an older version of River Pro could potentially point to a newer version of River and still have compilation work (it has however been marked as deprecated). I doubt too many people are in this situation though so we can probably remove it soon. * `stditerators`: Replaces some manual iteration patterns with newer standard library iterator APIs. For example this: for i := range typ.NumField() { field := typ.Field(i) Goes to this: for field := range typ.Fields() {�[27;5;106~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just since everything's fully available in Homebrew etc. now, here
take the opportunity upgrade Go to 1.27 and golangci-lint to 2.13.1 so
we can get our lint CI fully passing again.