fix(auth): reject token refresh and access validation for non-active users#940
Merged
RUKAYAT-CODER merged 2 commits intoJun 29, 2026
Merged
Conversation
|
@Agbasimere Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great work on this PR |
Contributor
Author
|
@RUKAYAT-CODER Pls kindly review. |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #802
Description
This PR resolves issue #802 by ensuring that user suspension (
UserStatus.SUSPENDED) and inactivity (UserStatus.INACTIVE) statuses are validated during both token refresh and access token validation. Previously, inactive or suspended users could continuously refresh their tokens and remain authenticated indefinitely.Changes
1. auth.service.ts
UserStatus.refreshTokens()to throw anUnauthorizedExceptionif the user status is notACTIVE.2. jwt.strategy.ts
UserStatusandUnauthorizedException.validate()to throw anUnauthorizedExceptionif the validating user status is notACTIVE.3. Unit Tests
SUSPENDEDandINACTIVEusers.Verification
npm run typechecksuccessfully without errors.