fix: ComponentVariableYAML.Proto panics on unconvertible value, aborting the whole project parse#9702
Merged
Merged
Conversation
…`value` A component or canvas input variable with a value that structpb cannot convert (e.g. a bare date like 2024-01-01, which yaml.v3 decodes to a time.Time) caused a panic in ComponentVariableYAML.Proto that aborted the entire project parse. Convert via pbutil.ToValue, which handles time.Time and other YAML-decoded types, and return any remaining error as a normal parse error scoped to the file.
Collaborator
Author
|
@codex: review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AdityaHegde
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComponentVariableYAML.Proto()panicked when a component or canvas input variable had avalue:thatstructpb.NewValuecannot convert. Since there is norecover()in the parser, a single badvalue:in one file aborted the entire project parse.value: 2024-01-01, which yaml.v3 decodes into atime.Time.pbutil.ToValue, which handlestime.Time(and other YAML-decoded types), so date defaults now work. Any remaining conversion error is returned as a normal parse error scoped to the file.TestComponentInputDateValue) covering the panic trigger.Manual testing steps:
rill start) on any working project.components/panic-test.yamlwith:invalid type: time.Timefrom the ProjectParser reconcile.2024-01-01T00:00:00Z; all other resources keep working.Checklist: