feat: sticky table of contents with scrollspy for canvas dashboards#9693
Open
rohithreddykota wants to merge 2 commits into
Open
feat: sticky table of contents with scrollspy for canvas dashboards#9693rohithreddykota wants to merge 2 commits into
rohithreddykota wants to merge 2 commits into
Conversation
Collaborator
|
A couple of UXQA items,
What do you think @nishantmonu51 ? |
rohithreddykota
force-pushed
the
rohithreddykota/canvas-toc-scrollspy
branch
from
July 17, 2026 18:41
0ac3794 to
52255cd
Compare
AdityaHegde
requested changes
Jul 20, 2026
| /* The rail itself: vertically centered, expanding to the full flyout on hover/focus (which | ||
| overlays the content to its right rather than reflowing it). `p-2` keeps the first and last bars | ||
| clear of the rounded corners so they aren't clipped. */ | ||
| .toc__panel { |
Collaborator
There was a problem hiding this comment.
Lets use toc-panel. The naming convention of double underscore is not standard for css. Same applies to double dash classes like toc__item--active.
| : "smooth"; | ||
| } | ||
|
|
||
| function jumpTo(event: MouseEvent, entry: TocEntry) { |
Collaborator
There was a problem hiding this comment.
We can move this and watchScrollEnd to a separate class that has logic from loc and scrollspy. Also we should move to svelte5 way for using cross file state. Check web-common/src/lib/store-utils/types.svelte.ts for reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a persistent, minimap-style table of contents to canvas dashboards (view surfaces only; not the iframe embed).
h1–h3) rendered insidemarkdowncomponents of the active tab — no new section primitive; stays in sync as content/tabs change via a debouncedMutationObserver.IntersectionObserver(no scroll-event math); exactly one active section, with the highlight pinned during click-to-scroll so it doesn't flicker through intermediate sections.prefers-reduced-motion) and updates the URL hash; deep-linking on mount is supported. Accessible:<nav aria-label>, real links,aria-current="location", focus rings, full heading as the accessible name.Checklist:
Developed in collaboration with Claude Code
