Repository navigation
Fixing path, platform name, and escape chars. - #15
Merged
Merged
Conversation
…nd fix windows dll discovery - Restore Linux aarch64/arm64 wheel detection in WowoolInstaller - Fix hasInstalledBinaries() to recognize wowool.dll on Windows - Add WowoolPaths.isWindows() and fix native/lib architecture folder resolution - Deterministically sort ICU DLL loading order (icudt -> icuuc -> other) on Windows - Only set WOWOOL_SDK_KEY when non-blank to prevent unexpected CRT env deletion - Remove unused buildMissingLicenseMessage dead code - Comply with Spotless formatting and Checkstyle standards - Add test coverage for Windows wowool.dll detection in WowoolInstallerTest
Owner
|
Hi @phforest-wow, Thank you for this PR and adding initial Windows runtime support to the SDK! Escaping path backslashes for I checked out your branch, resolved the formatting violations causing the CI to fail, and pushed a follow-up commit (
All matrix builds (Ubuntu & macOS runners on Java 22 and 23) as well as CodeQL checks are now 100% green. Feel free to review the changes and merge the PR when you're ready! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initial windows runtime build
Type of Change