Repository navigation
feat: step 9d turns the head with depth - #44
Merged
Merged
Conversation
The guide had no depth-driven step, though the parts it installs already support one. Step 9d reruns `propose` with `--full`/`--head` so the proposal carries a `turn` block (step 7's did not). It copies only that block into config.json and appends a four-second `turn` animation (0 / -12 / 0 / +12 / 0 degrees) to hello.anim.json. Then it rebuilds and renders native extremes. What the copy claims and does not: - The depths are the runs' scalar `depth_median`; no depth images are sampled. - The body does not turn. - The PSD route is skipped, since it carries no measured depth. Measured on parts 1.83.0 / core 2.82.0 / pose 1.6.0 / play 1.21.2, an empty npm consumer, with the guide's hand-placed joints: - build and check exit 0; - the same five WARN as before (elbow seam 1, skirt settling 4), none new; - the extremes are 1 s / -12 deg and 3 s / +12 deg; - torso and limb bones and vertices are unchanged across 49 sampled frames. Two hair marks already in the static shirt art show beside the moving side-lock tips at -12 deg. They are disclosed as ghosts in the README and the receipt, not repaired. The CI helpers pick up the new fence, and the browser check now asserts that the turn menu entry exists. The pool browser run reported canvas2d where try-it-browser expects webgl on both this branch and main's unchanged consumer. That is the pool's environment, not this diff; GitHub CI is the browser verdict. Closes #42 Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: step 9d turns the head with depth
The guide had no depth-driven step, though the parts it installs already
support one. Step 9d reruns
proposewith--full/--headso theproposal carries a
turnblock (step 7's did not). It copies only thatblock into config.json and appends a four-second
turnanimation(0 / -12 / 0 / +12 / 0 degrees) to hello.anim.json. Then it rebuilds and
renders native extremes.
What the copy claims and does not:
depth_median; no depth images aresampled.
Measured on parts 1.83.0 / core 2.82.0 / pose 1.6.0 / play 1.21.2, an
empty npm consumer, with the guide's hand-placed joints:
frames.
Two hair marks already in the static shirt art show beside the moving
side-lock tips at -12 deg. They are disclosed as ghosts in the README and
the receipt, not repaired. The CI helpers pick up the new fence, and the
browser check now asserts that the turn menu entry exists.
The pool browser run reported canvas2d where try-it-browser expects webgl
on both this branch and main's unchanged consumer. That is the pool's
environment, not this diff; GitHub CI is the browser verdict.
Closes #42
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
🤖 Generated with Claude Code