Repository navigation
docs(readme): See-through commands read config.seethrough; offload stays false - #41
Merged
Merged
Conversation
…ays false Step 3's config wrote seethrough.steps, seed and offload, but neither comfy seethrough command passed --config, so the block was never read for them. Its offload: true also contradicted the macOS route, which says offload assumes an NVIDIA card. Choice (b) of #40: the config keeps one owner for the seed and sets offload to false; both commands pass --config config.json (parts 1.82.1 binds it, rig-c/parts#861). The HOLLOW troubleshooting entry now names the config seed and a fresh --out directory. Rejected: - dropping the block, which leaves the HOLLOW remedy's config seed with no home; - adding --config alone, which turns offload on for Mac readers; - keeping true and special-casing the Mac, an unsafe shared default. Measured: a field-coverage check over README goes from 1 red (steps, seed and offload unread) to 0 (6/6 checks, every written field read by a command the guide runs). Closes #40 Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40.
Decision
This is choice (b).
config.jsonstays the one owner of the See-through settings, withoffload: false, and bothcomfy seethroughcommands pass--config config.json.@rig-c/parts1.82.1 binds those settings (rig-c/parts#861), so the guide now names 1.82.1 as its minimum.Why
Step 3 writes
seethrough.steps,seedandoffload, but neither command read them.The block's
offload: truealso contradicted the macOS route, which says offload assumes an NVIDIA card. A reader who added--configto make the block take effect would have turned offload on.The HOLLOW refusal's remedy text points at
config.seethrough.seed, so this troubleshooting entry now says how to use it, including a fresh--outdirectory.Measured
steps,seed,offloadwritten but unreadREADME.mdonlyCorrected claim from the card
The card called the block "never read". That is too broad:
assemblealready readsseethrough.resolution. The defect is that the comfy-side fields (steps,seed,offload) were unread.Rejected
--configalone. It turns offload on for Mac readers.trueand special-casing the Mac. That is an unsafe shared default.Not in this PR
The walkthrough WebP is not regenerated: its captions show no changed command. The card excluded regeneration, so the demo's guide digest is now historical, as
docs/demo/README.mddescribes.🤖 Generated with Claude Code