Repository navigation
docs(guide): demo animation at the top of the README (#35) - #39
Merged
Merged
Conversation
…guide's own outputs (#35) Frozen lane handoff, 7 files, hashes verified against the lane's FILES.sha256. The demo is regenerated on the next commit after the ankle fix (#36) lands. Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
The first demo was captured before #36 landed and showed the left-ankle slit. Regenerated once from guide commit 9c422e0 with @rig-c/parts 1.82.0, core 2.82.0, pose 1.6.0, play 1.21.2 on actual WebGL. Both capture passes are identical (raw screenshot digest and final WebP), 466,228 bytes, 7,750 ms, 720x600, 69 frames. Native idle and hello extremes at the left ankle show continuous fabric and shoe with no background slit. regenerate.ts gains an optional --guide-commit that records the source guide commit beside its digest; capture and encoding are unchanged. Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
Puts a demo animation at the top of the README, built from the guide's own outputs: the painting, the See-through layers, the bones and meshes, then the rig playing in the browser.
What is in it
docs/demo/walkthrough.webp: 466,228 B, 7,750 ms, 720×600, 69 frames, loops.docs/demo/regenerate.tsandencode.py: the route that rebuilds it.docs/demo/provenance.json: the receipt for the build.9c422e08(it now carries the guide rig: the left ankle tears in setup — a pale strip between sock and shoe that the painting does not have #36 ankle fix).docs/demo/README.md: how to rebuild it.Verification (this run)
--check(WebGL, 28 slots, idle + hello)Not claimed / known
The first commit is the frozen hand-off made before #36 landed. The second commit regenerates the demo on the fixed guide and adds an optional
--guide-committo the receipt; capture and encoding are unchanged.🤖 Generated with Claude Code