Repository navigation
docs(guide): claim the missing ankle painting with extend_painting order - #37
Conversation
…der and min_held_alpha (#36) The guide's left ankle left a 404 px band of painting no part owned, read as a gap at the ankle in the native render. @rig-c/parts 1.82.0 lets the config say who takes it: shin_l claims first (order 0, max_distance 15), foot_l second (order 1, max_distance 4), both admitting faint edge coverage below alpha 250. The guide pins parts 1.82.0 and adds that one config line with an explanation. Measured on the Nova pool from 20ad9d9: native band 404 -> 0 (shin +612, foot +19 px; the other 26 part PNGs byte-exact), residual 0 over setup, idle (81 frames) and hello (115 frames); gate and rig-parts check green. Not covered here: the try-it browser run on the pool fell back to canvas2d (the pool's Chromium has no WebGL) and stopped at the WebGL assertion. The run on a GitHub runner is the check for that step. Rejected: enlarging the shin's distance to take the foot's 7 px, which belong to foot_l. Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51aaa05901
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mkdir my-rig | ||
| cd my-rig | ||
| bun add @rig-c/parts @rig-c/core @rig-c/pose @rig-c/play | ||
| bun add --exact @rig-c/parts@1.82.0 @rig-c/core @rig-c/pose @rig-c/play |
There was a problem hiding this comment.
Once @rig-c/parts publishes a version newer than 1.82.0, the scheduled walkthrough will fail even if every tutorial step succeeds: scripts/try-it.ts fetches npm's latest versions and calls assertVersions(installed, before, after), which requires every installed package to equal latest. The try-it job in .github/workflows/adapters.yml runs this check on both daily polls and weekly forced runs, so the new pin prevents subsequent successful receipts and tested-record updates. Update the runner to validate explicitly pinned packages against the documented pin while retaining latest-version checks for unpinned packages.
Useful? React with 👍 / 👎.
The exact pin would fail the scheduled try-it run as soon as parts publishes past 1.82.0: try-it holds every installed package to npm's latest. The guide needs only the 1.82.0 extend_painting fields, so it installs latest and states the floor. (Codex review on #37, P2, adopted.) Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
|
Codex P2 (exact pin vs try-it's latest-version check): adopted. The guide now installs latest and states the 1.82.0 floor ( |
Closes #36.
The guide now pins
@rig-c/parts1.82.0 and adds one config line. It gives the unowned ankle band toshin_lfirst andfoot_lsecond throughextend_paintingorderandmin_held_alpha.20ad9d9)rig-parts checkforceon the pooladapters.yml,try_it: force, this branch) is the checkKnown and not in scope: a ghost at the hello elbow, filed separately.
🤖 Generated with Claude Code