Repository navigation
Conversation
Every clip now holds the two bars walk already held. All 12 joint discs read 0 px on 9 of 9 clips, and the ankle bend stays within 15 degrees of Spineboy on 9 of 9. Art is untouched since the cut rounds; the fix is pivots and keys. The rear foot target sat 18 px forward of the short rear leg, and run kept raw foot translations for a leg shorter than the source's, which folded the shin. The target moved under the hip with walk compensated, and run's foot translations were scaled to the leg. The shoulders ride torso3 while the torso is one rigid region on torso, so a bending spine carried them off the chest; jump and death now key the shoulder back onto it. Three caps sat up to 0.8 px off their pivots, and those origins were centred with no rest shift. HQ measured, not read from the report: rebuild byte-identical on 5 files, 241 samples per clip for bends, disc gate on jump, death and run, 0 of 42 Spineboy PNGs in the tree. Rejected: replacing v1 in place, because v1 is the documented single-painting fold boundary and consumers pin it, and deleting the round folders, because they are the provenance. They moved under rounds/ so the final rig reads first. Closes #80 Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
…nish # Conflicts: # README.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The ankle bars measured bones, and the bones were right: the painted front foot sat about 33 degrees toe up at idle against the original's 1, because its attachment was rotated. This round measures pixels. Attachments: front-foot rotation 47.48 to 16.48, rear-foot 110.11 to 108.61, each turned about the bone. Rest targets and the hip rose to meet the ground. HQ's own renders and a separate fit over the middle 50 % of the sole: planted difference from the original at most 4.72 degrees on any foot, idle lowest pixel 1.47 px off the ground. Joint discs 0 px on walk, run, jump and death at 1528x1864. Rejected: redrawing either foot, all 20 part images are unchanged, and a different measure per foot; one function reads both feet and both characters. Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com> Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes
rigboy/v2: Spineboy's skeleton, constraints and nine human animations on rigboy's own parts, cut at every joint.walkwas the only clip that held both bars; now all nine do. No art changed since the cut rounds.rig/in a copy: all 5 build files byte-identicalrun23.98° and 40.91°)jump, 43 px indeath)jump,death,run; the other six are the lane's figures@rig-c/playon all nine clips from a clean packageCauses. The rear foot target sat 18 px forward of the short rear leg, and
runkept raw foot translations for a leg shorter than the source's, so the shin folded. The target moved under the hip withwalkcompensated, andrun's translations were scaled to the leg. The shoulders ridetorso3while the torso is one rigid region ontorso, so a bending spine carried them off the chest;jumpanddeathkey the shoulders back onto it. Three caps sat up to 0.8 px off their pivots; those origins were centred with no rest-pose shift.Rejected. Replacing v1 in place: it is the documented single-painting fold boundary and consumers pin it. Deleting the round folders: they are the provenance, so they moved under
rounds/to let the final rig read first.Closes #80
🤖 Generated with Claude Code