Conversation
cursor
Bot
force-pushed
the
cursor/cross-join-metrics-tests-6895
branch
2 times, most recently
from
September 20, 2026 05:20
dca458f to
edf140f
Compare
Add a Rust test that asserts build_input_rows, input_rows, and output_rows stay stable when CrossJoinExec inputs are split into multiple batches. Related to apache#25333.
cursor
Bot
force-pushed
the
cursor/cross-join-metrics-tests-6895
branch
from
September 20, 2026 05:38
28f1b56 to
e12556c
Compare
Owner
Author
|
Superseded by apache#25530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Join metrics can be wrong without the query result failing.
CrossJoinExecnever assertedbuild_input_rowsorinput_rowson multi-batch input.What changes are included in this PR?
One test in
cross_join.rsruns the same 3×2 join withTestMemoryExecinputs split into batches of size 2 and 1 (TaskContext::default()). It assertsbuild_input_rows=3,input_rows=2, andoutput_rows=6. Single-batch coverage stays in existingtest_join.What is the testing strategy for this PR?
cargo test -p datafusion-physical-plan --lib joins::cross_joinAre there any user-facing changes?
No. Test-only.