Validate restG4 merge metadata#153
Open
cmargalejo wants to merge 2 commits into
Open
Conversation
Preserve and validate Geant4 metadata required by REST_Geant4_MergeRestG4Files. - deep-copy particle sources in TRestGeant4Metadata - preserve TRestGeant4PhysicsLists in merged outputs - validate Geant4 version and physics-list compatibility across inputs - merge TRestGeant4PhysicsInfo lookup metadata with conflict checks - add unit coverage for source copy and physics-info merge Refs #152
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve and validate the Geant4 metadata required by
REST_Geant4_MergeRestG4Files.This PR addresses the metadata-safety part of restG4 simulation-output merging. It updates
REST_Geant4_MergeRestG4Files.Cand related metadata classes so merged files preserve and validate the simulation metadata needed to interpret Geant4/restG4 outputs.Changes
TRestGeant4Metadata.TRestGeant4PhysicsListsin merged outputs.TRestGeant4PhysicsInfolookup metadata with conflict checks.What this does not solve
This PR does not implement full
AnalysisTreepreservation/merge behavior from #114. That remains a separate designdecision because it affects duplicate event-ID handling and tree merge semantics.
If that behavior is implemented later, restG4 files with populated
AnalysisTreeobjects could be merged morecompletely through this macro. However,
TRestDataSetis already intended to combineAnalysisTreedata, so thatworkflow should probably be prioritized unless maintainers decide otherwise.