[cknitt]

Windows CI ran only the GenType compiler unit tests and skipped several suites. This PR runs them on Windows:

• the full compiler OUnit suite
• the runtime docstring tests
• the analysis, tools and gentype tests
• the unicode and duplicated_symlinked_packages build tests

Fixes needed to get them passing:

• Async overlap unit test: its domains waited for each other by spinning. Every Domain.spawn stops the world, so on a runner with few cores the spinning domains starved the spawning domain and the test timed out. The domains now sleep instead.
• Analysis harness: the temporary source copy is written in binary mode, so the dumped source text keeps LF line endings on Windows. The test script also normalizes the native filePath in completion data to forward slashes.
• Tools tests: bsc runs -ppx through the system shell, and cmd.exe needs backslashes in the program path.
• duplicated_symlinked_packages: checks that the fixture was checked out as a real symlink. Without one it skips locally and fails on CI. It also normalizes path separators in the error output.
• CI workflow: sets core.symlinks, puts Git Bash back on PATH before these steps, and installs make if it is missing.

Still skipped on Windows, to be handled separately:

• The syntax roundtrip test and the format check. The formatter writes CRLF and doubles CRs inside multi-line comments, template literals and raw JS.
• The interactive output test, which needs ConPTY.
• The signal tests.

Checklist

• Added a changelog fragment (see changes/README.md), or no release notes are needed and a maintainer should apply changelog:skip.
• Added tests for the fix or feature.
• Signed off every commit for the DCO (git commit -s).

🤖 Generated with Claude Code

[github-actions]

Changelog

🏠 Internal

• Run the full compiler unit tests, runtime docstring tests, analysis, tools and gentype tests, and the unicode and duplicated_symlinked_packages build tests on Windows CI.

Semantic Diff

2 commits · Full page

Run the tests skipped on Windows in Windows CI

_{320399b · cknitt + Claude · Oct 25, 2026, 08:41 UTC}

Windows CI ran only the GenType compiler unit tests and skipped the runtime docstrings, analysis, tools and gentype tests and the unicode and duplicated_symlinked_packages build tests. They now run there. The async overlap unit test waited for its domains by spinning, which starved the spawning domain on few cores; its domains now sleep. The analysis harness writes its source copy in binary mode, the analysis and duplicate-package tests normalize Windows path separators, the tools test passes cmd.exe a backslash PPX path, and CI checks out symlinks and installs make.

✨ Run the test scripts through bash in the test Makefiles

_{3ca999e · cknitt + Claude · Oct 25, 2026, 10:59 UTC · new}

The analysis and tools Makefiles ran their scripts as ./test.sh. Make runs a recipe line without shell syntax directly rather than through SHELL, and Windows cannot run a shell script as a program, so Windows CI failed with error 193. The recipes now invoke bash, which several shebang-less scripts needed for brace expansion anyway.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.33%. Comparing base (5689a30) to head (3ca999e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #9041   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         456      456           
  Lines       64042    64042           
=======================================
  Hits        52086    52086           
  Misses      11956    11956           

Files with missing lines	Coverage Δ
analysis/src/cli.ml	80.30% <100.00%> (ø)
tests/ounit_tests/ounit_compiler_request_tests.ml	97.15% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9041

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9041

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9041

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9041

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9041

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9041

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9041

commit: 3ca999e

[github-actions]

Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9041

[cknitt]

@codex review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-25T11:16:56.206522Z	3ca999e	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 3ca999e2dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".