Enforce completion owners for public type aliases - #350
Merged
Conversation
jderochervlk
changed the title
Collaborator
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d908bf20e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
marked this pull request as ready for review
August 31, 2026 13:11
fhammerschmidt
approved these changes
Aug 31, 2026
jderochervlk
added a commit
that referenced
this pull request
Sep 3, 2026
## Summary - add a repository-wide CODEOWNERS rule - assign ownership to the human reviewers from #350 and @jderochervlk - automatically request this group on future pull requests ## Code owners - @fhammerschmidt - @brnrdog - @tsnobip - @jderochervlk ## Validation - confirmed every owner has write or admin access to the repository - confirmed GitHub reports no CODEOWNERS errors for the branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foo.taliases have@editor.completeFrom(Foo)on their internal backing typesElement.Impl.setAttributeNSreceiver typeWhy
Public modules expose internal record types through aliases. Several backing types either had a stale completion owner or no annotation, so editor completions could point at the internal module instead of the public API. The feature validator now enforces this relationship for future aliases while excluding intentional public-to-public
taliases.This addresses the first follow-up item in #342.
Validation
npm run buildnpm run check:featuresnpm testnpm run format:checkgit diff --check