Do not fail highlighting when the theme declares no languages - #125
Merged
Conversation
`CodeHighlightTheme(languages: {})` is a legitimate thing to build: an editor
that shows a file whose language it does not recognise still wants the theme
for its text colours. The payload then carried empty lists of sizes, `_run`
reduced them, and `Bad state: No element` was thrown — inside the isolate, so
highlighting died silently and all that was left was an unhandled exception in
the console.
Nothing to highlight is now answered with an empty result, as it already is
when there is no theme at all.
Member
|
LGTM, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
CodeHighlightTheme(languages: {})is a legitimate thing to build: an editorshowing a file whose language it does not recognise still wants the theme for
its text colours. The payload then carries empty lists of sizes,
_runreducesthem, and
Bad state: No elementis thrown — inside the isolate, sohighlighting dies silently and all that is left is an unhandled exception in the
console.
We hit it opening a
.logfile.The change
Nothing to highlight is answered with an empty result, exactly as it already is
when there is no theme at all.
Part of a small series from the same project: #122, #123, #124.