Repository navigation
Fix data loss, wrong values and monitor gaps - #4
Merged
Merged
Conversation
Intake: cumulative OTLP references are applied only after the data is stored; stream keys include all resource, scope and point attributes; late samples are ignored; histograms are subtracted by matching bucket layout; negative exponential buckets are kept; disk usage keeps its device tag. ClickHouse insert errors return 503; multi-chunk PostgreSQL writes are one transaction; series metadata is marked written only after success. Datadog Agent sketches keep their bins as weighted points. Monitors: groups that stop reporting go to No Data when notify_no_data is set; the no-data timer starts at the newest data point; evaluation_delay is applied; updates are validated as merged (no empty queries) and keep priority; log env and span group fields work; percentile(N), change and pct_change are computed; state is saved with a compare-and-set so one process announces each transition. Queries: formulas combine only matching groups and share one bucket size; data is selected from the exact start time; numeric filters ignore text values; facets and charts find flat attribute keys; totals and timeseries are computed separately; percentiles use the same interpolation on PostgreSQL and ClickHouse; the APM backfill is limited by span id; query_index follows the source formula. API and UI: dashboard updates lock the row and validate structure; list routes page when asked; the dashboard page reloads when its id changes; precision-0 numbers keep their zeros; live tail pages with the cursor and cancels stale requests. SDKs and server: the Node exporter treats a reset response as a retryable failure; Flask spans end when the response body is finished; SIGTERM drains requests, flushes rollups and closes the database before exit. Errors after monitor create and update are logged. Assisted-by: Replit
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fixes data loss, duplicate data, wrong chart values and monitor gaps found in a code review. Stacked on #3 (security hardening).
Intake (no lost or duplicated data)
devicetag.weightcolumn, with a migration on both storages.Monitors
notify_no_data, groups that stop reporting go to No Data. The no-data timer starts at the newest data point.evaluation_delayis applied to the query window.envand span monitors grouped by span fields now evaluate.percentile(N),changeandpct_changeare computed as written.Queries and API
query_indexfollows the source formula.UI, SDKs, server
Not changed in this PR: merging the PostgreSQL and ClickHouse query code, and replacing
anytypes, are larger refactors and will follow separately.How it was tested
pnpm run format:check, typechecks and unit tests pass (59 server tests, 10 new with the exact inputs from the review; Node SDK 6/6 with a reset test; Python SDK 6/6 with a streaming test)scripts/e2e.shpasses (for intake, query or storage changes): on PostgreSQL and ClickHouseAlso checked on a running server (PostgreSQL): numeric filter with a text value, flat attribute sum, total plus timeseries, log monitor grouped by env, empty-query rejection, priority kept, dashboard validation, monitor paging, and the earlier log-search checks.
~ written by ⠕ Replit