Repository navigation
ci(release): disable git hooks during automated release - #59
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 585 585
=========================================
Hits 585 585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
changes, explain why test-suite changes are unnecessary and describe the
documentation or metadata checks performed.
measurable-line coverage gates. Do not weaken checks to obtain a passing result.
not passing results.
Type
Issue (only for type
bug fix/feature change)Not applicable: this is a CI/CD release fix.
Description of the Change
Disable Husky hooks only for the automated
semantic-releasestep by settingHUSKY=0.The previous release run successfully completed npm OIDC authentication, but
@semantic-release/gittriggered the repositorypre-pushhook while pushingthe release commit/tag. That hook reran
npm testin the release job, where zshwas not installed, causing the release to fail.
The normal lint, regression, Bash/zsh compatibility and coverage jobs remain
unchanged.
Contract and Compatibility
Not applicable to the public Bash-base API.
No Bash/zsh runtime behavior, function contract, dependency, installation method
or coverage requirement is changed.
The only behavior change is that Git pushes performed by the automated
semantic-releasestep do not execute local Husky hooks. Required CI qualitygates still run before the release jobs.
Validation
Completed evidence from the previous GitHub Actions release run:
pre-pushhook rerannpm testand reported that zsh was unavailable
No production Shell code or tests are modified by this change.
Pending before merge:
masterrelease must complete the real npm OIDC publish successfullyPossible Drawbacks
The automated semantic-release Git push will bypass Husky hooks.
This is intentional because the same repository validation is already enforced
by required CI jobs before release. Developer-local hooks remain unchanged.