Repository navigation
Conversation
Collaborator
|
@dkwon17 : Unit tests seem to be failing. Probably some arguments need to be adjusted |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
===========================================
- Coverage 66.66% 55.78% -10.89%
===========================================
Files 4 5 +1
Lines 234 346 +112
===========================================
+ Hits 156 193 +37
- Misses 78 151 +73
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: David Kwon <dakwon@redhat.com>
Add missing parameter in getSpecExecTemplate function calls in exec_test.go Signed-off-by: David Kwon <dakwon@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: David Kwon <dakwon@redhat.com>
…field Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: David Kwon <dakwon@redhat.com>
…ilently giving up Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
# Conflicts: # manifests/web-terminal.clusterserviceversion.yaml
rohanKanojia
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…APIServer watcher backoff
What does this PR do?
Adds functionality to get TLS profile and adherence policy from the
apiserverresource.The TLS profile is then applied to the web-terminal-operator pod and the web-terminal-exec
DevWorkspaceTemplatevia env var.What issues does this PR fix or reference?
https://redhat.atlassian.net/browse/WTO-353?search_id=ecd2f8bd-0ab7-4924-9d77-6cef1d370be1&referrer=quick-find&xpis=eyJicmlkZ2UiOiJxdWlja0ZpbmQiLCJpZCI6IjE3OTIxODI4OTc4MTIiLCJzb3VyY2UiOiJqaXJhLXNvZnR3YXJlIn0%3D
Is it tested? How?
To fully test this feature, we need changes from redhat-developer/web-terminal-exec#142.
I built and pushed the exec image here:
quay.io/dkwon17/web-terminal-exec:tls.I've also built the operator image:
quay.io/dkwon17/web-terminal-operator:tlsand the index image:quay.io/dkwon17/web-terminal-operator-index:tlswhich can be used to test this PR.To test this PR:
1. Apply the catalog source and subscription:
2. Confirm no tlsAdherence or tlsSecurityProfile is set:
3. Check logs that mention that TLS min version is set to TLS 1.2
In the
web-terminal-controller-*pod logs:Start a web terminal and check the web terminal's web-terminal-exec container log:
4. Set tlsadherence
Run:
and verify that the
web-terminal-controller-*pod eventually restarts and prints this log:5. Set the profile to modern
Run:
and verify that the
web-terminal-controller-*pod eventually restarts and prints this log:Next, if the web terminal from step 2 is still running, stop the web terminal by setting
started: falsein the web terminal'sDevWorkspace.Start the web terminal again, and verify that the web terminal's pod's web-terminal-exec container has the following log:
For example:
