[build] Fix tests by using tsc for all builds and proper ESM module a…#5939
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5939 +/- ##
===========================================
+ Coverage 32.37% 47.72% +15.35%
===========================================
Files 85 106 +21
Lines 6505 9841 +3336
Branches 1349 2229 +880
===========================================
+ Hits 2106 4697 +2591
- Misses 4399 5141 +742
- Partials 0 3 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…liasing - Convert test/bootstrap.js to test/bootstrap.ts for automatic tsc transpilation - Load bootstrap via NODE_OPTIONS before extension activation to register ESM-to-CJS module aliases - Use absolute paths in bootstrap to correctly resolve aliased modules from any context - Unset ELECTRON_RUN_AS_NODE in test environment to prevent workspace file execution errors - Remove manual bootstrap require() calls from test index files - Alphabetize package.json devDependencies This ensures tests run with tsc-built (unbundled) code rather than esbuild-bundled code, allowing Sinon stubs to work correctly. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com> Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
vrubezhny
force-pushed
the
use-esbuild-for-tests
branch
from
cc306f2 to
4f704c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…liasing
This ensures tests run with tsc-built (unbundled) code rather than esbuild-bundled code, allowing Sinon stubs to work correctly.
Assisted-By: Claude Sonnet 4.5 noreply@anthropic.com