Add unit tests for labels, links, and topology rollout actions - #301
Conversation
Signed-off-by: trdoyle <trdoyle@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe changes expand tests for ChangesTest coverage updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds coverage for shared UI rendering and topology rollout actions without modifying production behavior. No current merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 11.30% 12.79% +1.49%
==========================================
Files 169 172 +3
Lines 6679 6838 +159
Branches 2235 2308 +73
==========================================
+ Hits 755 875 +120
+ Misses 5923 5722 -201
- Partials 1 241 +240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds unit tests for shared UI components and topology rollout dropdown actions.
Covers:
-MetadataLabels: custom numLabels
-ExternalLink: missing text, children vs text, empty children
-Topology actions: delete rollout id/label + modal callback; edit rollout yaml href (inc missing name/namespace)
Jira:
https://redhat.atlassian.net/browse/GITOPS-10537
https://redhat.atlassian.net/browse/GITOPS-10539
Will need to be ported to release-4.18 aswell.
Run tests:
$ pnpm test
$ pnpm test -- src/gitops/components/shared/MetadataLabels/MetadataLabels.test.tsx src/gitops/utils/components/ExternalLink/ExternalLink.test.tsx src/gitops/topology/actions/creators.test.ts