Skip to content

GITOPS-11176: return null from rollout decorator so Topology URL links render - #299

Merged
keithchong merged 1 commit into
redhat-developer:mainfrom
dipakkarde:GITOPS-11176-topology-route-decorator
Sep 3, 2026
Merged

GITOPS-11176: return null from rollout decorator so Topology URL links render#299
keithchong merged 1 commit into
redhat-developer:mainfrom
dipakkarde:GITOPS-11176-topology-route-decorator

Conversation

@dipakkarde

Copy link
Copy Markdown
Contributor

Summary

Workloads → Topology should show the Route/Open URL decorator on workloads (Deployments, etc.) when gitops-plugin is enabled.

The plugin registers a Topology decorator on upperRight, the same corner as that Route decorator. For workload nodes it returned an empty fragment (<></>). Topology uses the first truthy decorator in that corner, so the fragment hid the Route icon.

Return null so the Route decorator can render.

Fixes: https://issues.redhat.com/browse/GITOPS-11176

Test plan

  • gitops-plugin enabled: Deployment with a Route shows the Topology Route/Open URL decorator

Made with Cursor

…s render

Empty fragment on upperRight is truthy and hides the workload Route decorator.

Signed-off-by: Dipak Karde <dkarde@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 44f40b16-1a68-468b-868f-9fd496986a2c


Comment @coderabbitai help to get the list of available commands.

@keithchong keithchong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dipakkarde . I tested it out and it fixes the issue.

@keithchong

Copy link
Copy Markdown
Collaborator

/ok-to-test

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 12.76%. Comparing base (3bd1dab) to head (96746ce).
⚠️ Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...opology/decorators/getArgoRolloutNodeDecorator.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   11.30%   12.76%   +1.46%     
==========================================
  Files         169      172       +3     
  Lines        6679     6838     +159     
  Branches     2235     2308      +73     
==========================================
+ Hits          755      873     +118     
+ Misses       5923     5724     -199     
- Partials        1      241     +240     
Flag Coverage Δ
unit-tests 12.76% <0.00%> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@svghadi

svghadi commented Sep 3, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keithchong
keithchong merged commit 0a2a15c into redhat-developer:main Sep 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants