GITOPS-11176: return null from rollout decorator so Topology URL links render - #299
Conversation
…s render Empty fragment on upperRight is truthy and hides the workload Route decorator. Signed-off-by: Dipak Karde <dkarde@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Comment |
keithchong
left a comment
There was a problem hiding this comment.
Thanks for the PR @dipakkarde . I tested it out and it fixes the issue.
|
/ok-to-test |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 11.30% 12.76% +1.46%
==========================================
Files 169 172 +3
Lines 6679 6838 +159
Branches 2235 2308 +73
==========================================
+ Hits 755 873 +118
+ Misses 5923 5724 -199
- Partials 1 241 +240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
Summary
Workloads → Topology should show the Route/Open URL decorator on workloads (Deployments, etc.) when
gitops-pluginis enabled.The plugin registers a Topology decorator on
upperRight, the same corner as that Route decorator. For workload nodes it returned an empty fragment (<></>). Topology uses the first truthy decorator in that corner, so the fragment hid the Route icon.Return
nullso the Route decorator can render.Fixes: https://issues.redhat.com/browse/GITOPS-11176
Test plan
gitops-pluginenabled: Deployment with a Route shows the Topology Route/Open URL decoratorMade with Cursor