Skip to content

cherry-pick Add unit tests for health & application set status to release-4.18 branch - #298

Merged
keithchong merged 2 commits into
redhat-developer:release-4.18from
aali309:GITOPS-10536-console-plugin-status-tests-4.18
Sep 2, 2026
Merged

cherry-pick Add unit tests for health & application set status to release-4.18 branch#298
keithchong merged 2 commits into
redhat-developer:release-4.18from
aali309:GITOPS-10536-console-plugin-status-tests-4.18

Conversation

@aali309

@aali309 aali309 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Cherry-pick of: #290 to release-4.18 branch

Signed-off-by: trdoyle <trdoyle@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 073de8ca-a8c5-45c2-85d6-cda0727ad662

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Cherry-picked tests from main used PF6 CSS variables; release-4.18 still renders PF5 tokens.

Signed-off-by: Atif Ali <atali@redhat.com>
@aali309
aali309 force-pushed the GITOPS-10536-console-plugin-status-tests-4.18 branch from 1df8a19 to 88031ca Compare September 2, 2026 17:30
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-4.18@610a68f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rc/gitops/components/shared/ApplicationSetList.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-4.18     #298   +/-   ##
===============================================
  Coverage                ?   12.76%           
===============================================
  Files                   ?      172           
  Lines                   ?     6839           
  Branches                ?     2309           
===============================================
  Hits                    ?      873           
  Misses                  ?     5960           
  Partials                ?        6           
Flag Coverage Δ
unit-tests 12.76% <93.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keithchong keithchong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Same as main. Thanks @aali309 . FYI, @trdoyle81

@keithchong
keithchong merged commit be94411 into redhat-developer:release-4.18 Sep 2, 2026
5 checks passed
@aali309
aali309 deleted the GITOPS-10536-console-plugin-status-tests-4.18 branch September 2, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants