Skip to content

fix: enable Delete ApplicationSet (And Apps) for namespace-scoped users (GITOPS-10780) - #287

Merged
keithchong merged 1 commit into
redhat-developer:mainfrom
keithchong:10780-DeleteActionDisabled
Sep 2, 2026
Merged

fix: enable Delete ApplicationSet (And Apps) for namespace-scoped users (GITOPS-10780)#287
keithchong merged 1 commit into
redhat-developer:mainfrom
keithchong:10780-DeleteActionDisabled

Conversation

@keithchong

Copy link
Copy Markdown
Collaborator

See GITOPS-10780

@openshift-ci
openshift-ci Bot requested review from aali309 and wtam2018 September 1, 2026 21:44
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 2c62af48-2f71-46d7-8ab5-8b3b3b09d621


Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.45%. Comparing base (3bd1dab) to head (deb1f7f).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   11.30%   12.45%   +1.14%     
==========================================
  Files         169      171       +2     
  Lines        6679     6835     +156     
  Branches     2235     2310      +75     
==========================================
+ Hits          755      851      +96     
- Misses       5923     5983      +60     
  Partials        1        1              
Flag Coverage Δ
unit-tests 12.45% <ø> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aali309
aali309 previously approved these changes Sep 2, 2026

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(GITOPS-10780)

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong
keithchong force-pushed the 10780-DeleteActionDisabled branch from dc41788 to deb1f7f Compare September 2, 2026 16:14
@keithchong keithchong changed the title fix: enable Delete ApplicationSet for namespace-scoped users (GITOPS-10780) fix: enable Delete ApplicationSet (And Apps) for namespace-scoped users (GITOPS-10780) Sep 2, 2026

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keithchong
keithchong merged commit 4980c92 into redhat-developer:main Sep 2, 2026
5 checks passed
@keithchong

Copy link
Copy Markdown
Collaborator Author

Thanks Atif for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants