Skip to content

ci: add Slack PR notification workflow#31

Closed
stevefulme1 wants to merge 2 commits into
redhat-cop:mainfrom
stevefulme1:slack-pr-notifications
Closed

ci: add Slack PR notification workflow#31
stevefulme1 wants to merge 2 commits into
redhat-cop:mainfrom
stevefulme1:slack-pr-notifications

Conversation

@stevefulme1

@stevefulme1 stevefulme1 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a GitHub Actions workflow that sends Slack notifications on PR events (opened, closed/merged, reopened, and reviews)
  • Notifications go to the OVM Slack channel via incoming webhook
  • Requires SLACK_WEBHOOK_URL repo secret to be configured

Test plan

  • Add SLACK_WEBHOOK_URL secret to the repo
  • Open a test PR and verify Slack notification appears in channel
  • Verify merged PR notification works

🤖 Generated with Claude Code

@stevefulme1 stevefulme1 requested a review from sabre1041 as a code owner April 15, 2026 18:57
@spyrexd spyrexd mentioned this pull request Apr 29, 2026
Merged
4 tasks
@stevefulme1 stevefulme1 force-pushed the slack-pr-notifications branch from 2d8c044 to 21715b6 Compare June 18, 2026 12:43
@burigolucas burigolucas self-requested a review June 26, 2026 08:45
@stevefulme1 stevefulme1 force-pushed the slack-pr-notifications branch from 21715b6 to ed3b2ed Compare June 26, 2026 15:21
burigolucas
burigolucas requested changes Jun 29, 2026
View reviewed changes

@burigolucas burigolucas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree with the new workflow, but please see my comments to some specific files that need to be addressed.

Comment thread CONTRIBUTING.md
Comment thread COPYING Outdated
Comment thread SECURITY.md
@burigolucas burigolucas mentioned this pull request Jun 29, 2026
Merged
4 tasks
stevefulme1 added a commit to stevefulme1/openshift_virtualization_migration that referenced this pull request Jun 29, 2026
@stevefulme1
fix: address PR review feedback
f246057 
- Revert CODE_OF_CONDUCT.md, CONTRIBUTING.md to main (handled in PR redhat-cop#31)
- Remove COPYING and SECURITY.md (handled in PR redhat-cop#31)
- Add explicit permissions block to gitleaks workflow
- Bump gitleaks-action from v2 to v3
@stevefulme1 stevefulme1 closed this Jul 1, 2026
@burigolucas burigolucas reopened this Jul 2, 2026
@burigolucas

burigolucas commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@stevefulme1 please, remove from the PR all files except the workflow for Slack notification. For the workflow itself, please, replace the content with the workflow from this PR redhat-cop/openshift_virtualization_ops#9 which is working properly. If the notification fails, we need to double check the webhook secret.

@burigolucas burigolucas self-requested a review July 2, 2026 12:14
@stevefulme1 stevefulme1 force-pushed the slack-pr-notifications branch from a9721b3 to fac4a04 Compare July 2, 2026 17:54
@stevefulme1

stevefulme1 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

PR cleaned up — only the Slack notification workflow remains. Content matches the working workflow from redhat-cop/openshift_virtualization_ops PR #9. Ready for re-review.

@stevefulme1 @burigolucas
ci: add Slack PR notification workflow
fdc40ab 
Add GitHub Actions workflow that sends Slack notifications on PR events
(opened, closed/merged, reopened, and reviews). Uses the proven workflow
from openshift_virtualization_ops. Requires SLACK_WEBHOOK_URL repo secret.
@burigolucas burigolucas force-pushed the slack-pr-notifications branch from ddecc48 to fdc40ab Compare July 3, 2026 07:01
@burigolucas burigolucas closed this Jul 3, 2026
@burigolucas burigolucas reopened this Jul 3, 2026
@stevefulme1

stevefulme1 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@burigolucas All three review items are resolved:

  1. CONTRIBUTING.md — reverted to main's version (no diff)
  2. COPYING — removed (LICENSE covers GPL-3.0)
  3. SECURITY.md link — present under ## Documentation section at line 34 of README.md (not in the TOC)

The notify job failure is expected for fork PRs since secrets.SLACK_WEBHOOK_URL is not available — it will work once merged and the secret is configured.

Ready for re-review.

burigolucas
burigolucas previously approved these changes Jul 7, 2026
View reviewed changes

@burigolucas burigolucas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burigolucas

burigolucas commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

check notification on comment

@burigolucas burigolucas self-requested a review July 7, 2026 13:55
burigolucas
burigolucas approved these changes Jul 7, 2026
View reviewed changes

@burigolucas burigolucas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041

sabre1041 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Incorporated into #52

@sabre1041 sabre1041 closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burigolucas burigolucas burigolucas approved these changes
@sabre1041 sabre1041 Awaiting requested review from sabre1041 sabre1041 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevefulme1 @burigolucas @sabre1041