Bump dev dependencies, PHPUnit 13 - #976
Merged
Merged
Conversation
Run composer update and vendor/bin/jack raise-to-installed. PHPUnit 13 removed the RunClassInSeparateProcess attribute, which kept the pinned php version of PrePromotedTest from leaking into every later test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer update+vendor/bin/jack raise-to-installed, with PHPUnit taken from 11.5 to 13."require-dev": { - "phpunit/phpunit": "^11.5", + "phpunit/phpunit": "^13.2", - "rector/jack": "^0.5", + "rector/jack": "^1.0", - "symplify/easy-coding-standard": "^13.1", + "symplify/easy-coding-standard": "^13.2", - "symplify/phpstan-rules": "^14.10", + "symplify/phpstan-rules": "^14.12", }This one is not optional anymore - rector-src now requires
sebastian/diff^9 (rectorphp/rector-src#8220), which PHPUnit 11.5 cannot satisfy, socomposer updatefails onmainas it stands.One removed attribute took out 47 tests
PrePromotedTestpins a php version below constructor promotion:That was safe because the class ran in its own process. PHPUnit 13 dropped
RunClassInSeparateProcessin favour of the plural form, so the attribute silently stopped applying and the pinned version leaked into every test that ran after it - 47 fixtures lost their promoted constructors:PHPStan catches the removal too -
Attribute class PHPUnit\Framework\Attributes\RunClassInSeparateProcess does not exist.