[Symfony61] Do not report CommandConfigureToAttributeRector change when nothing is extracted - #1068
Merged
TomasVotruba merged 1 commit intoSep 22, 2026
Conversation
Member
|
CI needs fix first |
Contributor
Author
|
Error was not mine, but a bump of symplify/phpstan-rules, i opened another PR (#1069), i can rebase this branch when merged |
Member
|
Next time, you can include it here. To keep it simple |
…en nothing is extracted
GErpeldinger
force-pushed
the
fix-command-configure-to-attribute-has-changed
branch
from
September 22, 2026 22:21
d508879 to
976dee2
Compare
Contributor
Author
|
Ok thanks for the info, branch is rebase and ready 🚀 |
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9910
$hasChangedwas true as soon as the existing#[AsCommand]had arguments, even when nothing was taken fromconfigure(). It is now true only when a call is removed fromconfigure().Without the fix, the new skip fixture prints "File not changed but some Rector rules applied: CommandConfigureToAttributeRector".
🤖 Drafted with AI assistance.