Repository navigation
[CodingStyle] Keep partially qualified names as written on import names - #8932
Merged
Merged
Conversation
Names written as Field\TextField, ORM\Column or namespace\Sub\Foo are no longer imported. Fully qualified names and names created by rules are still imported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
withImportNames(), a name written partially qualified in the source is now kept as written, without a new option:as ORM,as Assert) were already kept. This PR adds regression fixtures for them: attributes,new,::class, types, docblocks, Doctrine annotations.use App\Search\Field; Field\TextField) and relative names (namespace\Sub\Foo) are now kept too. The check uses the parser'soriginalNameattribute.\App\Foo) and names that rules create are still imported.This is a behaviour change. 10 existing fixtures asserted that partially qualified names get imported. They are now
skip_*fixtures.Alternative to #8884, with no new
withImportNames()argument.