Skip to content

[tests] extend real class #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Nov 15, 2026
Merged

[tests] extend real class #8930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9e052d
[tests] extend real class
TomasVotruba Nov 12, 2026
9b99660
update NewTypeResolverTest expectation to SomeRealType parent
TomasVotruba Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/NewTypeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Rector\NodeTypeResolver\PHPStan\ObjectWithoutClassTypeWithParentTypes;
use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
use Rector\Tests\NodeTypeResolver\PerNodeTypeResolver\AbstractNodeTypeResolverTestCase;
use Rector\Tests\NodeTypeResolver\PerNodeTypeResolver\NewTypeResolver\Source\SomeRealType;

/**
* @see \Rector\NodeTypeResolver\NodeTypeResolver\NewTypeResolver
Expand All @@ -31,7 +32,7 @@ public function test(string $file, int $nodePosition, Type $expectedType, bool $
$isObjectType,
$this->nodeTypeResolver->isObjectType(
$newNodes[$nodePosition],
new ObjectType('Symfony\Bundle\TwigBundle\Loader\FilesystemLoader')
new ObjectType(SomeRealType::class)
)
);
}
Expand All @@ -47,7 +48,7 @@ public static function provideData(): Iterator
yield [__DIR__ . '/Source/NewDynamicNew.php', 0, $objectWithoutClassType, false];

$objectWithoutClassTypeWithParentTypes = new ObjectWithoutClassTypeWithParentTypes(
[new FullyQualifiedObjectType('Symfony\Bundle\TwigBundle\Loader\FilesystemLoader')]
[new FullyQualifiedObjectType(SomeRealType::class)]
);
yield [__DIR__ . '/Source/NewDynamicNewExtends.php', 0, $objectWithoutClassTypeWithParentTypes, true];
}
Expand Down
2 changes: 1 addition & 1 deletion tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/NewDynamicNewExtends.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ final class NewDynamicNewExtends
{
public function run()
{
new class extends \Symfony\Bundle\TwigBundle\Loader\FilesystemLoader {};
new class extends SomeRealType {};
}
}
8 changes: 8 additions & 0 deletions tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/SomeRealType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

namespace Rector\Tests\NodeTypeResolver\PerNodeTypeResolver\NewTypeResolver\Source;

class SomeRealType
{

}
Loading