Skip to content

Remove AddOverrideAttributeToOverriddenMethodsRector from PHP 8.3 and polyfill sets #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Aug 8, 2026
Merged

Remove AddOverrideAttributeToOverriddenMethodsRector from PHP 8.3 and polyfill sets #8321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a97f9be
remove AddOverrideAttributeToOverriddenMethodsRector from php83 and p…
TomasVotruba Aug 8, 2026
2cb3b91
[ci-review] Rector Rectify
actions-user Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions config/set/php-polyfills.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use Rector\Php80\Rector\NotIdentical\StrContainsRector;
use Rector\Php80\Rector\Ternary\GetDebugTypeRector;
use Rector\Php83\Rector\BooleanAnd\JsonValidateRector;
use Rector\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector;
use Rector\Php84\Rector\Class_\DeprecatedAnnotationToDeprecatedAttributeRector;
use Rector\Php84\Rector\Foreach_\ForeachToArrayAllRector;
use Rector\Php84\Rector\Foreach_\ForeachToArrayAnyRector;
Expand All @@ -34,7 +33,6 @@

// PHP 8.3
JsonValidateRector::class,
AddOverrideAttributeToOverriddenMethodsRector::class,

// PHP 8.4
ForeachToArrayAllRector::class,
Expand Down
2 changes: 0 additions & 2 deletions config/set/php83.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,12 @@
use Rector\Php83\Rector\BooleanAnd\JsonValidateRector;
use Rector\Php83\Rector\Class_\ReadOnlyAnonymousClassRector;
use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
use Rector\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector;
use Rector\Php83\Rector\FuncCall\CombineHostPortLdapUriRector;
use Rector\Php83\Rector\FuncCall\DynamicClassConstFetchRector;
use Rector\Php83\Rector\FuncCall\RemoveGetClassGetParentClassNoArgsRector;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->rules([
AddOverrideAttributeToOverriddenMethodsRector::class,
AddTypeToConstRector::class,
CombineHostPortLdapUriRector::class,
RemoveGetClassGetParentClassNoArgsRector::class,
Expand Down
9 changes: 1 addition & 8 deletions rules/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
use Rector\Rector\AbstractRector;
use Rector\ValueObject\MethodName;
use Rector\ValueObject\PhpVersionFeature;
use Rector\ValueObject\PolyfillPackage;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Rector\VersionBonding\Contract\RelatedPolyfillInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

Expand All @@ -40,7 +38,7 @@
*
* @see \Rector\Tests\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector\AddOverrideAttributeToOverriddenMethodsRectorTest
*/
final class AddOverrideAttributeToOverriddenMethodsRector extends AbstractRector implements MinPhpVersionInterface, RelatedPolyfillInterface, ConfigurableRectorInterface
final class AddOverrideAttributeToOverriddenMethodsRector extends AbstractRector implements MinPhpVersionInterface, ConfigurableRectorInterface
{
/**
* @api
Expand Down Expand Up @@ -228,11 +226,6 @@ public function provideMinPhpVersion(): int
return PhpVersionFeature::OVERRIDE_ATTRIBUTE;
}

public function providePolyfillPackage(): string
{
return PolyfillPackage::PHP_83;
}

/**
* @param ClassReflection[] $parentClassReflections
*/
Expand Down
10 changes: 2 additions & 8 deletions src/Bridge/SetProviderCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,10 @@
final readonly class SetProviderCollector
{
/**
* @var SetProviderInterface[]
* @param SetProviderInterface[] $setProviders
*/
private array $setProviders;

/**
* @param SetProviderInterface[] $extraSetProviders
*/
public function __construct(array $extraSetProviders = [])
public function __construct(private array $setProviders = [])
{
$this->setProviders = $extraSetProviders;
}

/**
Expand Down
Loading