[Sets] Drop PHPUnitSetProvider from the collector - #8295
Merged
Conversation
rectorphp/rector-phpunit#758 moves every per-version rule into the composer-based set, leaving no ComposerTriggeredSet in that package. Its remaining sets are reachable through the PHPUnitSetList constants, which is what withComposerBased(phpunit: true) already uses, so the provider is removed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to rectorphp/rector-phpunit#758, same shape as #8292 for Symfony.
That PR moves every per-version rule into
composer-based.php, each bound to thephpunit/phpunitversion its target API is available from, so noComposerTriggeredSetis left in the package. WhatPHPUnitSetProviderstill listed were three plain sets, all reachable throughPHPUnitSetList::COMPOSER_BASED,PHPUNIT_CODE_QUALITYandANNOTATIONS_TO_ATTRIBUTES.No behavior change for
withComposerBased(phpunit: true)— it addsPHPUnitSetList::COMPOSER_BASEDdirectly and never routes throughSetGroup::PHPUNIT.Merge this before rectorphp/rector-phpunit#758, which deletes the class. The reverse order leaves main instantiating a class that no longer exists.
tests/Setgreen: 12 tests, 15 assertions.