[Php81] Skip ArrayToFirstClassCallableRector when the arg type does not accept a Closure - #8288
Merged
Conversation
…sure A first class callable is a Closure. Passing it to a parameter typed "array" or "string|array|null" is a fatal TypeError at runtime. Fixes rectorphp/rector#9563
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9563
A first class callable is a
Closure. When the array callable is passed as an argument to a parameter that cannot hold aClosure—array, or a union likestring|array|SomeObject|null— the converted code fatals at runtime:Before / after
public function run() { - return new SomeObjectWithArrayArgument([$this, 'name']); + return new SomeObjectWithArrayArgument([$this, 'name']); // unchanged now }A
callableparameter still converts:public function run(SomeObjectWithArrayArgument $someObjectWithArrayArgument) { - $someObjectWithArrayArgument->withCallable([$this, 'name']); + $someObjectWithArrayArgument->withCallable($this->name(...)); }How
New
ArgNotAcceptingClosureNodeVisitor(aDecoratingNodeVisitorInterface, so attribute decoration stays separate from node changes) resolves the called function/method reflection, matches each array argument to its parameter — by name for named args, by position otherwise, falling back to a trailing variadic — and marks the argument withAttributeKey::IS_ARG_NOT_ACCEPTING_CLOSUREwhen the parameter type rejectsClosure. The rule bails out on that attribute.