[Php85] Deprecate NestedFuncCallsToPipeOperatorRector and SequentialAssignmentsToPipeOperatorRector - #8286
Merged
Merged
Conversation
…ssignmentsToPipeOperatorRector Both rules turn working code into |> pipe chains, but where a pipe helps depends on the code around it: * they can build extremely long chains that break readability * the cut-off point is an opinionated boundary, not a mechanical one * SequentialAssignmentsToPipeOperatorRector removes intermediate variables that carry naming and may be re-used later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates both pipe-operator rules.
Both rules take working code and rewrite it into a
|>chain. Whether that is an improvement depends entirely on the surrounding code, so it cannot be decided mechanically:NestedFuncCallsToPipeOperatorRectoreven exposes it as aminimum_depthoption, which is the tell that there is no correct default.SequentialAssignmentsToPipeOperatorRectordeletes the intermediate variables. Those names document what each step produces, and they may be re-used later.If needed, implement as custom rule with your specific boundaries and needs.
NestedFuncCallsToPipeOperatorRector
Neither rule was registered in any set, so nothing is removed from `php85.php` or the levels. Rules now implement `DeprecatedInterface`, `refactor()` throws, and their tests are dropped — same shape as #8283.