[CodingStyle] Deprecate WrapEncapsedVariableInCurlyBracesRector

rules/CodingStyle/Rector/Encapsed/WrapEncapsedVariableInCurlyBracesRector.php

@@ -5,17 +5,17 @@
 namespace Rector\CodingStyle\Rector\Encapsed;
 
 use PhpParser\Node;
-use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Scalar\InterpolatedString;
-use PhpParser\Token;
+use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
+use Rector\Exception\ShouldNotHappenException;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
 /**
- * @see \Rector\Tests\CodingStyle\Rector\Encapsed\WrapEncapsedVariableInCurlyBracesRector\WrapEncapsedVariableInCurlyBracesRectorTest
+ * @deprecated This rule is deprecated, as it is a coding standard preference with no real value. Use a coding standard tool instead.
  */
-final class WrapEncapsedVariableInCurlyBracesRector extends AbstractRector
+final class WrapEncapsedVariableInCurlyBracesRector extends AbstractRector implements DeprecatedInterface
 {
     public function getRuleDefinition(): RuleDefinition
     {
@@ -51,28 +51,9 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        $hasVariableBeenWrapped = false;
-        $oldTokens = $this->getFile()
-            ->getOldTokens();
-
-        foreach ($node->parts as $index => $nodePart) {
-            if ($nodePart instanceof Variable && $nodePart->getStartTokenPos() >= 0) {
-                $start = $oldTokens[$nodePart->getStartTokenPos() - 1] ?? null;
-                $end = $oldTokens[$nodePart->getEndTokenPos() + 1] ?? null;
-
-                if ($start instanceof Token && $end instanceof Token && $start->text === '{' && $end->text === '}') {
-                    continue;
-                }
-
-                $hasVariableBeenWrapped = true;
-                $node->parts[$index] = new Variable($nodePart->name);
-            }
-        }
-
-        if (! $hasVariableBeenWrapped) {
-            return null;
-        }
-
-        return $node;
+        throw new ShouldNotHappenException(sprintf(
+            '"%s" rule is deprecated, as it is a coding standard preference with no real value',
+            self::class
+        ));
     }
 }

src/Config/Level/CodingStyleLevel.php

@@ -11,7 +11,6 @@
 use Rector\CodingStyle\Rector\ClassMethod\FuncGetArgsToVariadicParamRector;
 use Rector\CodingStyle\Rector\ClassMethod\MakeInheritedMethodVisibilitySameAsParentRector;
 use Rector\CodingStyle\Rector\ClassMethod\NewlineBeforeNewAssignSetRector;
-use Rector\CodingStyle\Rector\Encapsed\WrapEncapsedVariableInCurlyBracesRector;
 use Rector\CodingStyle\Rector\FuncCall\CallUserFuncArrayToVariadicRector;
 use Rector\CodingStyle\Rector\FuncCall\CallUserFuncToMethodCallRector;
 use Rector\CodingStyle\Rector\FuncCall\ConsistentImplodeRector;
@@ -57,7 +56,6 @@ final class CodingStyleLevel
         StringClassNameToClassConstantRector::class,
         CatchExceptionNameMatchingTypeRector::class,
         SplitDoubleAssignRector::class,
-        WrapEncapsedVariableInCurlyBracesRector::class,
         NewlineBeforeNewAssignSetRector::class,
         MakeInheritedMethodVisibilitySameAsParentRector::class,
         CallUserFuncArrayToVariadicRector::class,