[Configuration] Load single composer-based PHPUnit set in withComposerBased() - #8255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withComposerBased(phpunit: true)went through the set group machinery:SetGroup::PHPUNIT->SetProviderCollector->SetManager::matchBySetGroups()-> installed package resolving -> every matchingphpunit40.php...phpunit130.phpset pluscomposer-based.php.The
composer-based.phpset already binds each rule and rule configuration to the installedphpunit/phpunitversion on its own, viaComposerPackageConstraintInterfaceandruleWithConfigurationComposerVersionBound(). So the group lookup and the per-version sets are not needed - a single set include is enough.$setMap = [ SetGroup::TWIG => $twig, SetGroup::DOCTRINE => $doctrine, - SetGroup::PHPUNIT => $phpunit, SetGroup::SYMFONY => $symfony, ... ]; +if ($phpunit) { + $this->sets[] = PHPUnitSetList::COMPOSER_BASED; +}Behavior for the user stays the same:
final class SomeTest extends TestCase { - /** - * @dataProvider provideData - */ + #[\PHPUnit\Framework\Attributes\DataProvider('provideData')] public function test(): void { } }