[Set] Allow a version constraint in ComposerTriggeredSet - #8245
Merged
Conversation
…bare major version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComposerTriggeredSethardcodes'^' . $version, so a set can only be bound to a single major version:That is fine for the per-version upgrade sets, but it makes it impossible to register a set that applies across majors - such as rector-phpunit's new
composer-based.php, which should load for any installed PHPUnit and does its own per-rule version gating viaComposerPackageConstraintInterfaceandruleWithConfigurationComposerVersionBound().A bare version keeps behaving exactly as before; anything that is not a bare version is used as a constraint:
So both of these work:
This is what lets
withComposerBased(phpunit: true)pick up a package's composer-based set regardless of which PHPUnit major is installed, without registering the same set once per major version.Backward compatible - every existing
ComposerTriggeredSetin rector-src and the extension packages passes a bare version and keeps the^behaviour. Covered byComposerTriggeredSetTest, including the bare version cases.