Skip to content

[depre] Remove strict-booleans set deprecated since 2025-10 #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jul 31, 2026
+0 −28
Merged

[depre] Remove strict-booleans set deprecated since 2025-10 #8243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions config/set/strict-booleans.php
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/Configuration/RectorConfigBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@
use Rector\Symfony\Set\SymfonySetList;
use Rector\ValueObject\Configuration\LevelOverflow;
use Rector\ValueObject\PhpVersion;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Console\Output\ConsoleOutput;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symfony\Component\Finder\Finder;
use Webmozart\Assert\Assert;

Expand Down Expand Up @@ -692,8 +689,6 @@ public function withPreparedSets(
bool $instanceOf = false,
bool $if = false,
bool $earlyReturn = false,
/** @deprecated */
bool $strictBooleans = false,
bool $carbon = false,
bool $rectorPreset = false,
bool $phpunitCodeQuality = false,
Expand All @@ -705,13 +700,6 @@ public function withPreparedSets(
): self {
Notifier::notifyNotSuitableMethodForPHP74(__METHOD__);

if ($strictBooleans) {
$message = 'The "strictBooleans" set is deprecated as mostly risky and not practical. Remove it from withPreparedSets() method and use "codeQuality" and "codingStyle" sets instead. They already contain more granular and stable rules on same note.';

$symfonyStyle = new SymfonyStyle(new ArgvInput(), new ConsoleOutput());
$symfonyStyle->warning($message);
}

$setMap = [
SetList::DEAD_CODE => $deadCode,
SetList::CODE_QUALITY => $codeQuality,
Expand Down
1 change: 0 additions & 1 deletion src/Set/SetProvider/CoreSetProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public function provide(): array
new Set(SetGroup::CORE, 'Gmagick to Imagick', __DIR__ . '/../../../config/set/gmagick-to-imagick.php'),
new Set(SetGroup::CORE, 'Naming', __DIR__ . '/../../../config/set/naming.php'),
new Set(SetGroup::CORE, 'Privatization', __DIR__ . '/../../../config/set/privatization.php'),
new Set(SetGroup::CORE, 'Strict Booleans', __DIR__ . '/../../../config/set/strict-booleans.php'),
new Set(SetGroup::CORE, 'Type Declarations', __DIR__ . '/../../../config/set/type-declaration.php'),

new ComposerTriggeredSet(
Expand Down
5 changes: 0 additions & 5 deletions src/Set/ValueObject/SetList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ final class SetList

public const string DEAD_CODE = __DIR__ . '/../../../config/set/dead-code.php';

/**
* @deprecated As too strict and not practical. Use code quality and coding style sets instead.
*/
public const string STRICT_BOOLEANS = __DIR__ . '/../../../config/set/strict-booleans.php';

public const string GMAGICK_TO_IMAGICK = __DIR__ . '/../../../config/set/gmagick-to-imagick.php';

public const string NAMING = __DIR__ . '/../../../config/set/naming.php';
Expand Down
Loading